Change sign for nscng in hail/graupel budget

Katetc commented 3 years ago

There was discussion about this change, and Trade made it in the PPE code, but I think it should be added to the cam/release code as part of an earlier PR.

@@ -2145,7 +2205,7 @@ subroutine micro_mg_tend ( &
        nsubs(i,k)=0._r8

        if (do_hail .or. do_graupel) then        
-           dum = ((-nsagg(i,k)-nsubs(i,k)+ngracs(i,k))*precip_frac(i,k)-nprci(i,k)*icldm(i,k)-nscng(i,k)*lcldm(i,k))*deltat
+           dum = ((-nsagg(i,k)-nsubs(i,k)+ngracs(i,k))*precip_frac(i,k)-nprci(i,k)*icldm(i,k)+nscng(i,k)*lcldm(i,k))*deltat
        else
           dum = ((-nsagg(i,k)-nsubs(i,k)-nnuccr(i,k))*precip_frac(i,k)-nprci(i,k)*icldm(i,k))*deltat
        end if

andrewgettelman commented 3 years ago

Yes, I think that is a bug in my recollection? Maybe @trudeeidhammer can confirm this?

trudeeidhammer commented 3 years ago

Yes, the sign in front of nscng was wrong.

andrewgettelman commented 3 years ago

This I believe has been corrected by Trude on May 1 2021 in commit: https://github.com/ESCOMP/PUMAS/commit/d2110a0448046f97ed46204baa6adef312d62835

Not sure exactly where that is, but assuming it's done.

Katetc commented 3 years ago

Fixed in commit 65804082 , tag pumas_cam-release_v1.13

ESCOMP / PUMAS

Change sign for nscng in hail/graupel budget #19