ESCOMP / PUMAS

Parameterization for Unified Microphysics Across Scales
9 stars 12 forks source link

Bug fix for GPU-lized PUMAS codes #25

Closed sjsprecious closed 3 years ago

sjsprecious commented 3 years ago

Recently we realized some bugs in our GPU-lized PUMAS codes and we would like to fix them in this PR.

The detailed changes of this PR include:

These changes are BFB for CPU results.

Test suite: [aux_cam] Test machine: Cheyenne Test results: [BFB]

sjsprecious commented 3 years ago

Fine as long as it doesn't change answers. Seems like this bug might have affected the CPU code for sedimentation, or were we not passing i,k vectors?

Thanks @andrewgettelman . The CPU code for sedimentation will be changed too, but it is BFB.