Closed andrewgettelman closed 3 years ago
Hi @Katetc, not exactly sure what is next, and whether I am supposed to merge it or you are. So I'm going to wait and assume you merge it. I selected the release/cam branch for the merge, which seems like the place to go.
Thanks again for all the help. When this is merged I will update the CAM code and do a PR there.
Okay Jian's comments addressed, except for making the implicit fall speed call 2D (leaving as 1D for now in a loop). Answers change in a few spots: likely due to proper initialization of flx variable (which was never initialized before).
This PR is a first attempt at addressing the issues identified in Issue #28 :
1, fixes issue Possible removal of ice number limiter....doesn't work with new ice nucleation. #20
For the moment, 1 and 2 do not have switches, 3-5 have switches (though 3 is a bug fix). They will need science testing, but I have checked the code is functional in SCAM and 3D CAM and can be sent for review.