search

ESCOMP / PUMAS

Parameterization for Unified Microphysics Across Scales
9 stars 12 forks source link

PUMAS Update, first round draft changes tested in SCAM #29

Closed andrewgettelman closed 3 years ago

andrewgettelman commented 3 years ago

This PR is a first attempt at addressing the issues identified in Issue #28 :

1, fixes issue Possible removal of ice number limiter....doesn't work with new ice nucleation. #20

  1. adds in vapor deposition onto snow as a process
  2. Fall speed correction for rain/snow/graupel (namelist option turned on)
  3. Option for implicit fall speed (namelist option, initially off)
  4. Option for the accretion to see newly autoconverted rain (liquid only, namelist option, initially off).

For the moment, 1 and 2 do not have switches, 3-5 have switches (though 3 is a bug fix). They will need science testing, but I have checked the code is functional in SCAM and 3D CAM and can be sent for review.

andrewgettelman commented 3 years ago

Hi @Katetc, not exactly sure what is next, and whether I am supposed to merge it or you are. So I'm going to wait and assume you merge it. I selected the release/cam branch for the merge, which seems like the place to go.

Thanks again for all the help. When this is merged I will update the CAM code and do a PR there.

andrewgettelman commented 3 years ago

Okay Jian's comments addressed, except for making the implicit fall speed call 2D (leaving as 1D for now in a loop). Answers change in a few spots: likely due to proper initialization of flx variable (which was never initialized before).