ESCOMP / PUMAS

Parameterization for Unified Microphysics Across Scales
9 stars 12 forks source link

Gettelman refl mod #36

Closed andrewgettelman closed 2 years ago

andrewgettelman commented 2 years ago

Here are modifications for fixing rain reflectivity in PUMAS. This has been tested in other versions and re-ported into the latest pumas_cam_developmentV1.20 tag (that's the base code). However, this does not run when I tried to run it in my sandbox (the micro_mg_cam.F90 is not compatible with the latest cam tag).

So I have not verified that there are not typos in this code, but that should be easy to sort out when testing.

Katetc commented 2 years ago

Ran the aux_cam suite with the gettelman_pumas_update0821 PUMASdevelopment/cam_development branch and everything (but one) passed, but with many baseline differences due to pumas answer changes in the previous two tags. The only test that failed was ERS_Ln9_P288x1_Vnuopc.mpasa120_mpasa120.F2000climo.cheyenne_intel.cam-outfrq9s_mpasa120 - an MPAS and Vnuopc test that failed on create_newcase. This could be due to Cheyenne hiccups or a problem with our fork of cam_development. Either way, I don't think it is related to these changes, so I am going to merge this PR and make a new pumas tag.