Closed cacraigucar closed 2 years ago
@cacraigucar Thanks for this PR. I have a few minor comments related to the OpenACC directives. Should I commit directly to your branch or leave a comment here?
There are two ways to move forward (since @andrewgettelman tested with this).
Since @andrewgettelman has tested and I'd like to make sure the answers don't change from that run since he won't be able to run another test for a number of weeks, I prefer 1. That way I can make sure answers don't change. Thoughts?
If the notes are just related to ACC directives, then they won't change answers in a standard CPU run. I'm curious to see if his issues are related to the merge after his tag. Jian, could you please put your comments in this PR. If they are minimal, we can get them ironed out for this tag.
Hi @cacraigucar and @Katetc , thanks for your comments. I just left the comments at the places where I think some GPU directive changes are needed. They are not answer-changing either on CPU or GPU, but really a requirement for a consistent coding style. I think they can go in as the same tag as Cheryl's changes here but let me know if you have any questions.
Add refl10cm and reflz10cm diagnostics
Tested with ERP_D_Ln9_Vnuopc.ne30pg3_ne30pg3_mg17.F2000dev.cheyenne_intel.cam-outfrq9s