Open andrewgettelman opened 2 years ago
The 10cm reflectivity calculation recently introduced in PUMAS is calculating infinity at some locations when used with micro_mg_do_hail = .true.
This is due to a bug in the logic of the conditional to trap for this which currently only works with graupel.
The bug is here in this line
https://github.com/ESCOMP/PUMAS/blob/pumas_cam-release_v1.26/micro_pumas_v1.F90#L4286
if (do_hail .or. do_graupel .and. lamg(i,k) > 0._r8) then
should be:
if ((do_hail .or. do_graupel) .and. lamg(i,k) > 0._r8) then
I'll need some help in adding this to the next PUMAS tag and making a PR. Should be quick. One line change. Thanks!
The 10cm reflectivity calculation recently introduced in PUMAS is calculating infinity at some locations when used with micro_mg_do_hail = .true.
This is due to a bug in the logic of the conditional to trap for this which currently only works with graupel.
The bug is here in this line
https://github.com/ESCOMP/PUMAS/blob/pumas_cam-release_v1.26/micro_pumas_v1.F90#L4286
if (do_hail .or. do_graupel .and. lamg(i,k) > 0._r8) then
should be:
if ((do_hail .or. do_graupel) .and. lamg(i,k) > 0._r8) then
I'll need some help in adding this to the next PUMAS tag and making a PR. Should be quick. One line change. Thanks!