Closed sjsprecious closed 4 months ago
Thanks @Katetc . If it is just comment and you know what you want to put there, I am happy to update it in this PR together. But it is also fine if you want to make the changes in a separate tag.
Thanks @Katetc . If it is just comment and you know what you want to put there, I am happy to update it in this PR together. But it is also fine if you want to make the changes in a separate tag.
This is just a thought from me after doing this review. I may make an issue. You don't need to make any changes. I'm running tests now and I'll merge and tag very soon.
This PR removes the unused the variables in the OpenACC directives and fixes the bugs in the GPU code for
tau
warm rain scheme.Now the GPU code of
kk2000
,sb2001
andtau
schemes all pass the ensemble consistency test on Derecho.Fixed #56 Fixed #67