ESCOMP / atmospheric_physics

CCPP-enabled Atmospheric Physics
Apache License 2.0
4 stars 19 forks source link

fix constituent stdnames in state_converters.meta #58

Closed peverwhee closed 1 year ago

peverwhee commented 1 year ago

There is a mismatch in standard names for the following:

The only place that the first names were used was in state_converters.meta. Switching those to the second names listed for consistency. The corrected names match those listed in https://github.com/NCAR/CAMDEN/wiki/Metadata-standard-names

nusbaume commented 1 year ago

Agree with @cacraigucar , as the wrt versions follow the CCPP standard name rule number 5 here:

https://github.com/ESCOMP/CCPPStandardNames/blob/main/StandardNamesRules.rst#ccpp-standard-name-rules

However, it does look like we need to update the CAMDEN standard names list (whoops!), so I'll go ahead and do that now.

nusbaume commented 1 year ago

Hi All, just letting you know that I have updated the standard names page on CAMDEN to better take into account the CCPP standard name rules for constituents (at least for the ones associated with water). If you find anything wrong, or have any questions or concerns, please let me know. Thanks!

peverwhee commented 1 year ago

Thanks all! Closing this - will fix on the CAMDEN side