search

ESCOMP / mizuRoute

Reach-based river routing model
http://escomp.github.io/mizuRoute/
GNU General Public License v3.0
42 stars 52 forks source link

remove manage_externals #468

Open jedwards4b opened 4 months ago

jedwards4b commented 4 months ago

Remove manage externals from the mizuRoute repository

Part of #450

ekluzek commented 4 months ago

@jedwards4b thanks so much for putting this PR together. We appreciate your doing it.

Note, that we weren't planning on making this a requirement for cesm3_0_beta01, as the only need for externals management for mizuRoute is for the standalone version. So we figure this can come in after cesm3_0_beta01 is done.

nmizukami commented 4 months ago

Thanks Jim (@jedwards4b) for starting this, One thing I would like to check before merging this is: do we have to have alternative to pull externals? Here PIO. I cannot remember what the new method is to replace manage external. git submodule??

jedwards4b commented 4 months ago

@nmizukami git-fleximod is the replacement. I can add it to this PR but won't do it now as apparently this update is to be deferred.

ekluzek commented 2 days ago

We also need to bring in git-fleximod as a subtree as documented here:

https://github.com/ESMCI/git-fleximod/wiki#including-git-fleximod-in-other-repositories

ekluzek commented 2 days ago

@nmizukami will bring this in as is as the second step to moving to git-fleximod. We will do another PR to bring git-fleximod in as a git subtree.