search

ESDAnalysisTools / Satellite

A GUI for thunderstorm (under MIT license)
https://esdanalysistools.github.com/Satellite/
2 stars 0 forks source link

Support both pyside and pyqt #14

Open davidtrem opened 11 years ago

davidtrem commented 11 years ago

It would be nice to support both pyqt and pyside toolkit. Currently only pyqt is supported.

davidtrem commented 11 years ago

Received from Pascal:

Hi David,

It is done and ready to be ported on github. I also noticed the following point: In window “TLP with Leakage”: the name of X2 is overlapping the tips values In window “Leakage IVs”, Name of the Y axis out of the window: sizing issue

I also had to modify in file core.py the following line In_layout=QtGui.QHBoxLayout(self) To In_layout=QtGui.QHBoxLayout()

Otherwise you are getting the following warning: QLayout: Attempting to add QLayout “” to MainWin “”, which already has a layout

davidtrem commented 11 years ago

The QLayout warning was already fixed in the master here: https://github.com/ESDAnalysisTools/Satellite/commit/be83cd771793bcdf844dd6c7c118764e4903a448

davidtrem commented 11 years ago

May you provide screenshot for the two "layout" issues you mentionned:

You can drag and drop images (or select) images on the github interface of this issue: https://github.com/ESDAnalysisTools/Satellite/issues/14

psalome commented 11 years ago

David,

OK I will do.

I am investigating on the severe crash while closing the app. It is coming from the Import Menu. More especially from the line Load_file_action.triggered.connect(loader)

If you comment the line everything is fine.

psalome commented 11 years ago

Hi David,

I spent the day investigating the severe crash we have by using pyside and while closing the app.

As far as I understood, the issue comes from PySide which is not compatible to loggin.Handler due to the management of the emit() function available in both. So far I did not find a workaround to fix the issue.

As this function is mainly used in StatusBarLogHandler sub class to give message in the status bar during importing data, I have modified the code to keep this function while PyQt is used and to skip it if Pyside is imported.

I would be happy if you find a solution but I tried several stuff without any success!