search

ESGF / esgf-installer

ESGF P2P Node Installer
https://esgf.llnl.gov/
Other
20 stars 21 forks source link

Reverse apache-frontend checkout logic #551

Closed chrisacbr closed 6 years ago

chrisacbr commented 6 years ago

In production mode, the installer checks out the "master" branch, while in development it uses the specific release tag set in "esg-init". This appears to be the reverse of what's intended.

pchengi commented 6 years ago

No, this is exactly as intended. When a master release is cut, the latest tag is merged with master. When a devel install is done, it however doesn't default to the latest commit in the devel branch, but to the commit that is specified.

chrisacbr commented 5 years ago

Fair enough, but that strategy may cause some surprises; eg. if someone wants to redeploy the current version of ESGF they are using for whatever reason then the version of the config they'll get doesn't necessarily correspond with the version they are deploying so not a reproducible result. Granted that's probably not very common but nevertheless not entirely expected behaviour. Also, as a developer most of the time I'd be wanting the latest version of the code unless I specifically asked otherwise.