search

ESGF / esgf-installer

ESGF P2P Node Installer
https://esgf.llnl.gov/
Other
20 stars 21 forks source link

548 #565

Closed William-Hill closed 5 years ago

nathanlcarlson commented 5 years ago

@William-Hill It looks like this branch was branched off of the 545 branch and includes all the commits of that one. It also looks like commits somehow got doubled. Has this branch been tested? I left a comment on the other PR #564 .

Is thredds_conf/web.xml used anywhere? After a quick search it does not appear it is. It may be good to get rid of to avoid confusion.

Maybe we should close that PR and only do this one.

William-Hill commented 5 years ago

@nathanlcarlson That's true 548 was branched off of 545. Was intending to do them separately but had forgotten that I hadn't done the PR for 545 when I started 548. Going to remove that web.xml file and we can discard 545 and just merge 548