search

ESGF / esgf-installer

ESGF P2P Node Installer
https://esgf.llnl.gov/
Other
20 stars 21 forks source link

Postgres refactor #566

Closed nathanlcarlson closed 5 years ago

nathanlcarlson commented 5 years ago

While this isn't really a refactor, it is a significant clean up. It is directed to work on issues #561 and #560. This does not resolve #452. It is a fix that works with the current design of installer, #452 is suggestive of a new design. Attempting to make something object oriented fit with the current design would be difficult and probably not worth the effort if more (hopefully all) functionalities are moved to object oriented design.

nathanlcarlson commented 5 years ago

This has been tested with the currently requested #565 with a manual install. The installer did not fall over at any of the changed points.

nathanlcarlson commented 5 years ago

I am going to re-test this and will let you know the results.