search

ESGF / esgf-installer

ESGF P2P Node Installer
https://esgf.llnl.gov/
Other
21 stars 21 forks source link

Refactor add_tomcat_user() #629

Closed William-Hill closed 5 years ago

William-Hill commented 5 years ago

In Thredds.py, the add_tomcat_user() function is very clunky. It makes a call to add_another_user() which checks for a property in esgf.properties. This should be redesigned to where the tomcat.user key in esgf.properties can accept a comma separated list of users and then parse that list to create the users.

sashakames commented 5 years ago

What is the use case for more than one user? Not to say it shouldn't be done but so far I'm not aware of this need in our deployment.

William-Hill commented 5 years ago

@sashakames It's part of the classic installer in the setup_tds() function. I really don't see the use case of it but I left it in because it was in 2.x. If you think it isn't used, I can remove it altogether

sashakames commented 5 years ago

I remember the interface now. I think its reasonable to leave the implementation to future work if a need arises. I think there might have been the idea that more than a single "publisher" might need to reinitialize the thredds catalog (the only operation with the tomcat basic auth). But none to my knoweldge

William-Hill commented 5 years ago

@sashakames Ok, I'll remove the code for adding additional users for now.