search

ESGF / esgf-installer

ESGF P2P Node Installer
https://esgf.llnl.gov/
Other
20 stars 21 forks source link

Specify requests version #661

Closed sashakames closed 5 years ago

sashakames commented 5 years ago

We have a problem because requests updates while esgprep has a fixed version. Fixed versions are suggested for reproducibility, but we need agreement across components. Start with requests upgraded to 2.20.0 but use a version in esg_init.py or whichever procedure is used to describe the component versions

nathanlcarlson commented 5 years ago

I am not sure what you mean exactly @sashakames , but #657 was merged to address this. Would you like the fix a different way?

sashakames commented 5 years ago

I looked at the commit that pins the version. I see that this is in the bootstrap, so putting it in esg_init.py wouldn't make sense. When esgprep is updated to 2.20.0 we will just have to update the file as well. Requests is a core module so should be installed in all cases, while esgprep is data_node specific.