ESGF / esgf-pyclient

Search client for the ESGF Search API
https://esgf-pyclient.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
32 stars 18 forks source link

Import trial of `MyProxyClient` in `pyesgf/logon.py` outputs misleading error and incompatibility with `cryptography` from Anaconda `main` channel #83

Closed valeriupredoi closed 10 months ago

valeriupredoi commented 2 years ago

@agstephens et al, here are two issues in one, the reason why I chose to open one single issue instead of two is that these two things are related, in actuality it's a cause and effect one:

-> now this is not yer fault since myproxyclient is the package that is at fault here, but this is a heads up and maybe you see about this with myproxyclient guys

please catch the import exception and print it when _has_myproxy = False since that way you let the user know what the actual offending import is! :beer:

valeriupredoi commented 10 months ago

myproxyclient is now me, so am gonna have a quick look now

valeriupredoi commented 10 months ago

all deps from conda-forge now, so this can be closed. The try/except import without raising the original exception is not ideal but heyho, the gist is there