search

ESHackathon / CiteSource

http://www.eshackathon.org/CiteSource/
GNU General Public License v3.0
16 stars 2 forks source link

Cant build vignettes #130

Closed DrMattG closed 1 year ago

DrMattG commented 1 year ago

I am getting an error in the vignette building - I am not sure if it is local to me (Norwegian letters are causing some bugs in the latest R version - which is blooming annoying!).

Plot_sandbox.rmd fails at line 182: my_heatmap <- plot_source_overlap_heatmap(source_comparison)

I get Error in colSums(.) : 'x' must be numeric.

Is it just me who has this error?

TNRiley commented 1 year ago

Nope, I've got the same error. It looks like we'll need to revisit all of our plots as the switch to ASySD dependency has broken them. I'll be working to investigate...

heat plots, upset, bar charts, and tables are all affected

kaitlynhair commented 1 year ago

Oops sorry!! I was in a rush and forgot to push the vignette changes alongside the ASySD dependency.... Checked locally and it's working for me now. Essentially, dedup_citations returns a single df now as suggested previously and the merge_citations argument is no longer needed. Pushed fixes now!

DrMattG commented 1 year ago

That seems to have fixed it!