search

ESHackathon / CiteSource

http://www.eshackathon.org/CiteSource/
GNU General Public License v3.0
16 stars 1 forks source link

unique/duplicate Bar chart incorrectly displaying #132

Closed TNRiley closed 1 year ago

TNRiley commented 1 year ago

Haven't had a chance to see if there is something different with n_unique with the recent changes. Looks like something is affecting the bar chart though. This example is from the "Source Analysis Across Screening Phases" vignette image

LukasWallrich commented 1 year ago

This is related to the unknown issue - as unknown is added as the source to all screened and final articles, none of them are unique to another database. I am not quite sure what the unique unknown articles are - but let's fix #135 first, that should resolve this as well.

TNRiley commented 1 year ago

This is related to the unknown issue - as unknown is added as the source to all screened and final articles, none of them are unique to another database. I am not quite sure what the unique unknown articles are - but let's fix #135 first, that should resolve this as well.

Makes sense!

kaitlynhair commented 1 year ago

This should now be resolved - it seems to be working on my end. @TNRiley can you confirm if this is working as expected now?

TNRiley commented 1 year ago

@kaitlynhair It looks good in the vignettes, but I'm running into an issue in dedup that I'm working on getting past. Working out of the plot sandbox.

Run without ASySD call

unique_citations <- dedup_citations(citations) Error in ASySD::dedup_citations(raw_citations, merge_citations = TRUE, : unused arguments (shiny_progress = shiny_progress, show_unknown_tags = FALSE)

Run with ASySD call

unique_citations <- ASySD::dedup_citations(citations) Error in mutate(): ℹ In argument: label = ifelse(is.na(label), "unknown", paste(label)). Caused by error in ifelse(): ! object 'label' not found Backtrace:

  1. ASySD::dedup_citations(citations)
  2. base::ifelse(is.na(label), "unknown", paste(label))
kaitlynhair commented 1 year ago

Have you downloaded the latest version of ASySD? I'm wondering if that could be an issue

TNRiley commented 1 year ago

perfect!