ESHackathon / CiteSource

http://www.eshackathon.org/CiteSource/
GNU General Public License v3.0
16 stars 2 forks source link

CMD Note on dependencies #138

Closed TNRiley closed 1 year ago

TNRiley commented 1 year ago

In the CMD we have the following note. We should check to see what can be moved to Suggests

NOTE: This note is telling you that your package is importing from 21 different packages, which could make your package more vulnerable to issues if any of those packages become unavailable. Consider moving some of these to Suggests in the DESCRIPTION file and use them conditionally.

TNRiley commented 1 year ago

Just for fun I made some scripts that count the number of times functions from a package are called using the :: operator. Also a list of these packages. Here is what I got on our .R scripts. Potentially useful for identifying what to move?

package count 1 ASySD 1 2 CiteSource 1 3 DT 2 4 UpSetR 3 5 dplyr 203 6 forcats 4 7 ggnewscale 1 8 ggplot2 58 9 glue 31 10 gt 26 11 gtExtras 1 12 htmltools 12 13 magrittr 1 14 purrr 38 15 rlang 16 16 scales 2 17 shiny 1 18 stringr 52 19 tibble 10 20 tidyr 19 21 tidyselect 19 22 tools 5 23 utils 7

TNRiley commented 1 year ago

tools and utils are base, so we can remove and test

rootsandberries commented 1 year ago

Just a note to say that I don't think the CMD note is taking tools and utils into account (it's only finding 21, so I think base packages are included in its count).

LukasWallrich commented 1 year ago

We gave some dead dependencies there -

The warning concern only imports, not suggests

TNRiley commented 1 year ago

cleaned up imports as discussed