ESHackathon / CiteSource

http://www.eshackathon.org/CiteSource/
GNU General Public License v3.0
16 stars 2 forks source link

Shiny - disconnect from server on upload #172

Closed TNRiley closed 1 month ago

TNRiley commented 1 month ago

Unable to upload files, disconnected from server message.

chriscpritchard commented 1 month ago

This may be due to the server size limit set up for uploaded files, how big is the file you’re attempting to upload?

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: Trevor Riley @.> Sent: Wednesday, May 22, 2024 3:58:49 PM To: ESHackathon/CiteSource @.> Cc: Subscribed @.***> Subject: [ESHackathon/CiteSource] Shiny - disconnect from server on upload (Issue #172)

Unable to upload files, disconnected from server message.

— Reply to this email directly, view it on GitHubhttps://github.com/ESHackathon/CiteSource/issues/172, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOA7YTK3HLQOYNNXV7OBK3ZDSXCTAVCNFSM6AAAAABID2U3ISVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTANZXGQ4DMNI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

DrMattG commented 1 month ago

I think that is the case - I can run it with 11 RIS files that are around 3,66MB each (1000 records each)

We can add eg. options(shiny.maxRequestSize = 10 * 1024^2) to the shiny code to set the upper limit of 10MB

TNRiley commented 1 month ago

Interesting, mine are very small. <200 citations.

DrMattG commented 1 month ago

Interesting, mine are very small. <200 citations.

Can you send them to me and I will see if I can recreate the error

LukasWallrich commented 1 month ago

We already set a limit of 250 MB or 2GB (depending on where the app is run) - see here. So that should not be the issue ...

chriscpritchard commented 1 month ago

In that case it’s probably an issue with the files themselves?

From: Lukas Wallrich @.> Reply to: ESHackathon/CiteSource @.> Date: Friday 24 May 2024 at 14:11 To: ESHackathon/CiteSource @.> Cc: Chris Pritchard @.>, Comment @.***> Subject: Re: [ESHackathon/CiteSource] Shiny - disconnect from server on upload (Issue #172)

We already set a limit of 250 MB or 2GB (depending on where the app is run) - see herehttps://github.com/ESHackathon/CiteSource/blob/82ec4eacc70657b02dd84a9e73bcc9e99b3fba29/R/CiteSource.R#L37. So that should not be the issue ...

— Reply to this email directly, view it on GitHubhttps://github.com/ESHackathon/CiteSource/issues/172#issuecomment-2129501974, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAOA7YXPQFHZWIDHB3AEYF3ZD436RAVCNFSM6AAAAABID2U3ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGUYDCOJXGQ. You are receiving this because you commented.Message ID: @.***>

TNRiley commented 1 month ago

We talked in the meeting and think that we just need to deploy the latest version of the shiny. Let's also check about how the auto deploy may be fixed.

TNRiley commented 1 month ago

In that case it’s probably an issue with the files themselves?

No, it's specifically with the web app. Shiny works fine in R. It has to do with the web app being out of sync with recent deploys. Nothing to do with size or the files.

LukasWallrich commented 1 month ago

Deployment is now working - so the current Shiny should always be available on https://litrev.shinyapps.io/CiteSource_latest/ - @TNRiley can you check if this issue arises there?

TNRiley commented 1 month ago

Deployment is now working - so the current Shiny should always be available on https://litrev.shinyapps.io/CiteSource_latest/ - @TNRiley can you check if this issue arises there?

Looks good, no issues. I think we'll just have to talk about what site we want to point to. The one we were using previously was https://estech.shinyapps.io/citesource/