search

ESHackathon / CiteSource

http://www.eshackathon.org/CiteSource/
GNU General Public License v3.0
16 stars 1 forks source link

cite_label and cite_string not being applied in shiny #198

Closed TNRiley closed 1 month ago

TNRiley commented 2 months ago

This issue appears to be limited to the web shiny. Works fine in the local shiny.

cite_label or cite_string tags are not being applied. This can be seen in the tables and in the exported data.

LukasWallrich commented 2 months ago

For me, it does not work locally either. It appears that the shiny::observeEvent(input$tbl_out_cell_edit, { is not triggered. Can you recheck it it works for you locally with the latest code? It it no longer works after you update, we should be able to narrow down where it broek

TNRiley commented 2 months ago

I'm up to date and it's working locally. I'm running the "working_example" vignette and things look good.

LukasWallrich commented 2 months ago

To double check: you are editing the table in Shiny to add labels and strings, and they show up in the Visualisation page? Can you share your sessionInfo()?

TNRiley commented 2 months ago

@LukasWallrich sent you that session info and a short .mp4 video to show you what I'm seeing

TNRiley commented 1 month ago

I'm running things locally and it's not working now, not sure why it had been when I tested earlier. Tested on the same vignette data and others. Also checked locally using both the run_shiny and runshiny. I haven't done any digging on this yet, but wanted to let you know that I'm at least in line with you now.

LukasWallrich commented 1 month ago

That's helpful, I guess :/ I'm on holiday until the middle of next week, will have a proper look then.

On Fri, 23 Aug 2024, 16:53 Trevor Riley, @.***> wrote:

I'm running things locally and it's not working now, not sure why it had been when I tested earlier. Tested on the same vignette data and others. Also checked locally using both the run_shiny and runshiny. I haven't done any digging on this yet, but wanted to let you know that I'm at least in line with you now.

— Reply to this email directly, view it on GitHub https://github.com/ESHackathon/CiteSource/issues/198#issuecomment-2307256863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOK6NGO55XYJUN42Z6MPK7LZS5EE5AVCNFSM6AAAAABL2NEUY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXGI2TMOBWGM . You are receiving this because you were mentioned.Message ID: @.***>

TNRiley commented 1 month ago

Found the issue. It was this change that was related to the reimport issue #177. SInce the need for this to work is more important than the re-import I'm reverting the script back to what it had been. I'm working on some videos for the Global Evidence Summit poster. I'm going to re-open #177 and note this.

TNRiley commented 1 month ago

reverted to previous script. FYI @LukasWallrich - I'll start looking at another fix for #177