Feature 109 funding

[mbjones]

These are the proposed changes for Funding to use the @reverse keyword on fundedItem. It includes both updates to the Dataset guidance docs, a new example, a new figure, and an ADR describing the impact.

Discussion of these features was in issue #109

[mbjones]

@datadavev can you give this a quick review so I can merge it into develop if there is nothing controversial? I think you already looked over the changes based on your comments in issue #109 . Thanks.

[mbjones]

Yeah, makes sense. How about if I add a sentence at the end explaining that and alternative would be to use the @graph representation?

[datadavev]

Yeah, makes sense. How about if I add a sentence at the end explaining that and alternative would be to use the @graph representation?

Kind of feels more like there should be a general guideline on JSON-LD, but adding a sentence here could be helpful. Perhaps something like:

Note that using @reverse is a convenience that can simplify the construction of JSON-LD for describing datasets since it places the funders as objects within the SO:Dataset object rather than composing multiple objects within a @graph list which may be more complicated to generate. Logically there is no difference. In either case, consumers of JSON-LD should take appropriate steps to process the content to achieve an expected JSON structure (e.g. with framing) or treat the JSON-LD as an RDF graph and query accordingly.

[mbjones]

Thanks @datadavev I incorporated your feedback into the branch and PR.

[mbjones]

Thanks, @smrgeoinfo, good catch. I just harmonized the language used to "Funder ID" and added a link in sha e87b2e0. Does that address your feedback?

[smrgeoinfo]

looks good