ESIPFed / science-on-schema.org

science-on-schema.org - providing guidance for publishing schema.org as JSON-LD for the sciences
Apache License 2.0
113 stars 33 forks source link

Feature 135 json list examples guidance #187

Closed ashepherd closed 2 years ago

ashepherd commented 2 years ago
mbjones commented 2 years ago

@ashepherd Your PR for the element ordering with @list looks good, but I not there are a bunch of changes in the PR to the checksum feature (which was already merged to develop in https://github.com/ESIPFed/science-on-schema.org/pull/171), and to the funding feature (which was already merged to develop in https://github.com/ESIPFed/science-on-schema.org/pull/163). I'm unclear why your PR has these changes, and I would want to check to be sure nothing gets accidentally reverted. Is your PR up-to-date wrt develop? I can look in more detail later if needed.

ashepherd commented 2 years ago

just set the merge from master to develop. that fixed it

mbjones commented 2 years ago

Thanks. LGTM.

ashepherd commented 2 years ago

typos fixed!