search

ESIPFed / science-on-schema.org

science-on-schema.org - providing guidance for publishing schema.org as JSON-LD for the sciences
Apache License 2.0
109 stars 31 forks source link

subjectOf example should have a contentURL #216

Closed smrgeoinfo closed 2 years ago

smrgeoinfo commented 2 years ago

https://github.com/ESIPFed/science-on-schema.org/blob/develop/guides/Dataset.md#metadata

the DataDownload content for the subjectOf property should have a contentURL that locates the referenced metadata record. currently have:

"subjectOf": {
      "@type": "DataDownload",
      "name": "eml-metadata.xml",
      "description": "EML metadata describing the dataset",
      "encodingFormat": ["application/xml", "https://eml.ecoinformatics.org/eml-2.2.0"],
      "dateModified":"2019-06-12T14:44:15Z"
    }

suggest adding:

"subjectOf": {
      "@type": "DataDownload",
      "name": "EML metadata for dataset blah-blah-blah",
      "description": "EML metadata describing the dataset",
      "encodingFormat": ["application/xml", "https://eml.ecoinformatics.org/eml-2.2.0"],
      "contentURL":"https://example.com/metadata/eml-metadata.xml",
      "dateModified":"2019-06-12T14:44:15Z"
    }
mbjones commented 2 years ago

Makes sense +1

smrgeoinfo commented 2 years ago

created PR to put into develop.

mbjones commented 2 years ago

PR has been merged and closed.