search

ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
119 stars 33 forks source link

ISSUE-107 sosa:sample vs sosa:sampling issue #127

Closed lewismc closed 5 years ago

lewismc commented 5 years ago

Simply formalized the PR for #107 Work done by @dr-shorthair

lewismc commented 5 years ago

@charlesvardeman can you review. Also, @rduerr can you have a look?

charlesvardeman commented 5 years ago

This looks like a good way to solve the issue and reviewed the changes. We will have to discuss whether some upper parent classes will be necessary to ground the process concept.

dr-shorthair commented 5 years ago

I've disentangled the mapping-provenance-reification material from the sweet-ssn mapping and moved that to a separate issue/branch

dr-shorthair commented 5 years ago

Thanks @rduerr

  1. I just added comments to Sample and Sampling, giving a narrative definition of each (short)
  2. Is this module (reprSciModel) the correct place for these concepts?
rduerr commented 5 years ago

@dr-shorthair

  1. Definitions look ok to me.

  2. I don’t think there is any other place in SWEET that they could go!