search

ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
119 stars 33 forks source link

fix URI typo in SHACL file as well as on prefix.cc #166

Closed brandonnodnarb closed 5 years ago

brandonnodnarb commented 5 years ago

In checking the PR for #165, I've notice conflicting URIs.
In the ttl file for phenAtmoWindMesoscale the URI is https://sweetontology.net/phenAtmoWindMesoscale.ttl

However, in the SHACL file and on prefix.cc the URI is http://sweetontology.net/phenAtmoWindMesostcale/ (note the 't' in scale)

I assume all the URIs in the SWEET files are sans the errant 't'. A quick spot check seems to verify this. Easiest resolution seems be to fix the SHACL typo and add the correct URI to prefix.cc and then have everyone go "upvote" the correct URI. (Rather than changing the URIs in every SWEET ttl file.)

I'm happy to go ahead, but thought I'd log an issue incase I've missed something obvious. (It's been that kind of week.)

lewismc commented 5 years ago

Good catch @brandonnodnarb what a PITA but the good thing is that it shows peer review is working... eventually :) If you can go ahead and register the new entry in prefix.cc and then create the PR that would be great.

brandonnodnarb commented 5 years ago

addressed with PR #167

please also go to: http://prefix.cc/sophatmowm and upvote the corrected URI (the one without the 't' in mesoscale)

lewismc commented 5 years ago

DONE :)

brandonnodnarb commented 5 years ago

merged