ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
119 stars 33 forks source link

ISSUE-169 Address erroneous usage of punning - a name can only be use…d for one kind of property #170

Closed lewismc closed 4 years ago

lewismc commented 4 years ago

This is the start of #169 however I am not sure if it is the correct way to go.

I cannot check if the edits I've made actually address the punning. Reasoning being that even if I load sweetAll.ttl via the local file, I am quite certain that the imported ontologies are loaded from the http://sweetontology.net/... IRI instead of the local file.

Having searched on the protege mailing list and not been successful tracking down an answer, I'm going to ask what needs to be done to force the imports to be loaded from local disk. I'll write back here with any result.

smrgeoinfo commented 4 years ago

Create a catalog-v001.xml file that redirects the loading to the local file locations. Here’s a start:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>

lewismc commented 4 years ago

@smrgeoinfo thanks for the input. I already had the catalog file but didn't know syntax. Do you think we should provide one of these with SCM?

smrgeoinfo commented 4 years ago

In general, for most users who are connected to the web, getting the files from the online URL's seems better. Providing a catalog xml file to load the ontology from a local checkout is handy for offline users and debugging, but it shouldn't be in the src directory, so the user has to actively move the catalog file into src to load locally. An explanation in the repo readme would be useful.

lewismc commented 4 years ago

@smrgeoinfo I agree with you. I took a look at https://github.com/ESIPFed/sweet/pull/148 and it looks like we never merged into master! If you want I can take this issue on... please let me know. Sorry for the screw up previously.

ignazio1977 commented 4 years ago

what needs to be done to force the imports to be loaded from local disk. I'll write back here with any result.

I used an OWLOntologyIRIMapper to redirect to local files. Code below.

LoadSweetTestCase.txt

lewismc commented 4 years ago

Closing in place of #171