search

ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
115 stars 33 forks source link

ISSUE-217 qudt alignment #221

Closed dr-shorthair closed 3 years ago

dr-shorthair commented 3 years ago

Ran Agreement-Maker but it didn't find a lot of matches, while getting a lot wrong. So I reverted to a manual process.

This graph contains alignments from reprSciUnits to QUDT Units and QUDT Prefixes. Most can be matched, and I've advised QUDT of the ones that are missing from their vocabulary - see https://github.com/qudt/qudt-public-repo/issues/231

All except one alignment uses skos:exactMatch as the alignment predicate. For reprSciUnits:year the conversion factor is different to all four of the definitions for Year in QUDT so I just left it at skos:closeMatch for now.

There will also be potential for alignment to QUDT QuantityKinds but that looks like quite a big job.

Related to #217

carueda commented 3 years ago

@dr-shorthair I just noted this review request ... sorry, I won't be able to review for the time being. Since I'm noting 3 reviewers now and that 3 reviews are required for merge, may I ask you to consider other possible extra reviewers?

dr-shorthair commented 3 years ago

was there a version of QUDT that you aligned SWEET master branch against? If so, do you have any idea of how quickly this alignment may become stale... if at all?

Since v2 QUDT is maintained continuously. So I aligned SWEET to current state. I am on the QUDT TAB and am pushing to clarify the policy around revisions, but one thing that has to be non-negotiable is that any published URI will remain de-referenceable, though the representation might be just a pointer to a preferred representation. That should ensure no 404 links, i.e. the alignment should not go stale.

As for automating the alignment - well the SWEET representation is not very expressive, so most of the work would be on SWEET side. I did this one manually - a bit tedious but I judged it would be quicker than trying to automate this time.

lewismc commented 3 years ago

Understood @dr-shorthair thanks for the commentary.

lewismc commented 3 years ago

@graybeal can you please take a look at @dr-shorthair 's most recent additions? Thank you

graybeal commented 3 years ago

@graybeal can you please take a look at @dr-shorthair 's most recent additions? Thank you

can't right now, no. (can't even find them, not enough time or github-fu. But I thought I made that pull request and he's included it, so there isn't anything else to review?

dr-shorthair commented 3 years ago

@graybeal the mapping graph is here: https://github.com/ESIPFed/sweet/blob/issue217-qudt-alignment/alignments/sweet-qudt-mapping.ttl I adjusted the mapping for year following your suggestion - https://github.com/ESIPFed/sweet/blob/issue217-qudt-alignment/alignments/sweet-qudt-mapping.ttl#L385 Need you to switch your review to 'accept' then it can be merged.