search

ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
117 stars 33 forks source link

ISSUE-231 switch from xsd:double to xsd:decimal (revealed with ABETCO) #269

Closed jmkeil closed 1 year ago

jmkeil commented 2 years ago

Solving #231 by replacing xsd:double with xsd:decimal for conversion values and beyond.

Please not, that this is a breaking change, as it might change datatypes used in tools to represent parsed values.

brandonnodnarb commented 1 year ago

it is potentially incompatible with some existing applications, so feedback on this should be sought before proceeding.

Indeed. I interpret this a 'more' correct. I advocate making the change and highlighting the change it in the v3.6 release info.

I think I corrected the negative to positive exponent issues. Can someone please verify?

rduerr commented 1 year ago

@jmkeil Can you please fix the conflicts in src/reprSciUnits.ttl. I was concerned about changing the abbreviation for Siemens from S to G, in particular...

r0sek commented 1 year ago

Approved

brandonnodnarb commented 1 year ago

closed on accident.

jmkeil commented 1 year ago

@jmkeil Can you please fix the conflicts in src/reprSciUnits.ttl. I was concerned about changing the abbreviation for Siemens from S to G, in particular...

The wrong symbols did not origin from my PR, but from this PRs parent version (69655a7). The symbols have been fixed in my PR #271, which was merged after this PRs parent commit. Preserving the correct symbols is a matter of propper merging.