search

ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
117 stars 33 forks source link

[BUG] A moraine is not a plain of any kind! #280

Closed rduerr closed 1 year ago

rduerr commented 1 year ago

Description

The term moraine is currently classed as a type of plain (http://sweetontology.net/realmLandGlacial/Moraine) and it isn't clear from the definitions what the difference between glacial moraine (http://sweetontology.net/realmLandGlacial/GlacialMoraine) and just plain moraine is.

What would you like to see changed?

Please update the hierarchy to move it out from under glacial plain (actually with the exception of the terms that end in the word plain, all of the terms under glacial plain should be moved up to be parallel concepts to glacial plain at the very least).

Attribution

(https://orcid.org/0000-0003-4808-4736)

r0sek commented 1 year ago

Agree.

  1. Glacial Plain and Moraine (http://sweetontology.net/realmLandGlacial/Moraine) are parallel concepts a both are formed by glacier-related processes, so Moraine should be moved out from under Glacial Plain
  2. Glacial Moraine (http://sweetontology.net/realmLandGlacial/GlacialMoraine): moraines are exclusively formed by glacier-related processes, so "glacial moraine" is redundant and incorrect, and its SWEET entry has no definition, so it should be removed.
rduerr commented 1 year ago

Agreed with @r0sek

r0sek commented 1 year ago

@brandonnodnarb has made the changes in Protégé and will create pull request/merge when branch is uploaded. This also fixes issues #277 and #279