ESIPFed / sweet

Official repository for Semantic Web for Earth and Environmental Terminology (SWEET) Ontologies
Other
120 stars 34 forks source link

Adding USGS Lithology term definitions #290

Open brandonnodnarb opened 10 months ago

brandonnodnarb commented 10 months ago

Adding scope notes from USGS Lithology terms.

This is meant a test to discuss tags/annotation axioms.

Initial discussion points for the next SWEET working session:

  1. dcterms:source links versus text
  2. dcterms:creator vs dcterms:contributor vs other vs nothing
  3. multiple dcterms:source tags versus dcterms:source and a skos:exactMatch tag
cmungall commented 10 months ago

Spurious diffs. See https://douroucouli.wordpress.com/2014/03/30/the-perils-of-managing-owl-in-a-version-control-system/

For OBO ontologies we use the ODK and ensure roundtripping through the owlapi to avoid spurious diffs

On Wed, Jan 17, 2024 at 1:14 PM rduerr @.***> wrote:

@.**** commented on this pull request.

On src/matrAnimal.ttl https://github.com/ESIPFed/sweet/pull/290#discussion_r1456492672:

What is with the extra space on the front of many of the subClassOf and label statements?

— Reply to this email directly, view it on GitHub https://github.com/ESIPFed/sweet/pull/290#pullrequestreview-1828201685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOPFMHQB2IPZG4SADJDYPA5L5AVCNFSM6AAAAABB2NZ5EWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRYGIYDCNRYGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

brandonnodnarb commented 10 months ago

Thanks, @cmungall. This, and the rest of the definitions, will have been created using ROBOT templates. I suspect it's OWLAPI version mismatch issue. I am going through the ODK tutorials, but thanks for the tip.

brandonnodnarb commented 10 months ago

Per our SWEET Ontology Working Session yesterday, we discussed the following:

  1. change skos:scopeNote to skos:definition irrespective of how the annotation is presented in the source vocab
  2. dcterms:creator should be changed to something more appropriate for this task
    • prov:wasGeneratedBy could work; need to ensure object of statement is an agent instead of an action
    • dcterms:contributor could work
  3. need a tag for reviewers of term relationships where appropriate
    • pro:reviewer from the 'Publishing Roles Ontology' (SPAR) seems intuitive; does it need further role setup?
    • dcterms:contributor could work if not used in 2 and assuming appropriate notes in documentation/wiki are added
  4. where a link to a resource is available, useskos:exactMatch for the link as well as dcterms:source for the natural language text---e.g. "USGS Lithologic terms"
  5. instead of embedding annotation axioms in source ontology module/turtle file, generate a separate ttl file for each vocabulary; similar to rdfs:comments from previous versions
brandonnodnarb commented 10 months ago

As per the notes, this PR is now stale. @brandonnodnarb will issue a new PR which reflects discussed changes.

brandonnodnarb commented 9 months ago

per Convo at today's meeting, suggest for

  1. use dcterms:contributor
  2. use CReDIT:validation