search

ESLyric / feedback

Feedback for ESLyric
12 stars 0 forks source link

Please remove the LyricsOnDemand lyric source #149

Closed TT-ReBORN closed 5 months ago

TT-ReBORN commented 5 months ago

Hi @ESLyric,

please remove the "not working anymore" LyricsOnDemand lyric source, it is causing a memory leak nowadays. The script is finding the div lyric container and its looping endlessly. I think their lyrics are loaded now from external source async. Thanks and cheers.

Copied excerpt from my Git Discussions:

@acstrp,

thanks! I found the issue, it is the Lyrics on Demand search script that is not working anymore causing a buffer overflow. I guess the website devs implemented some anti-scraping measures to prevent lyric scrappers to fetch the lyrics from their website. Not a tragic loss because their lyrics sources were the same as musixmatch.

Go to foobar's Preferences ( CTRL + P ) > Tools > ESLyric > Lyric Option > Lyric Sources and find the LyricsOnDemand (Unsynced) lyrics source, right click on it and select Delete. Restart foobar and all should be good.

Test for few days ( should be working stable now ) and report back and remind me or post here https://github.com/ESLyric/feedback/issues and inform ttsping ( dev of ESLyric ) to remove the "not working anymore" LyricsOnDemand lyric source.

I will then also remove it from the Georgia-ReBORN repo here.

Thanks a lot for your debugging, it was a big help!

-Tom

ESLyric commented 5 months ago

Removed.