ESMCI / ccs_config_cesm

CESM CIME Case Control System configuration files
3 stars 46 forks source link

correct way to add aws settings #51

Closed jedwards4b closed 2 years ago

jedwards4b commented 2 years ago

The previously added aws settings were being activated on all systems because mach attribute was used in the wrong place. We probably need better testing and error checking for this.

fischer-ncar commented 2 years ago

@briandobbins have you had a chance to try this on aws. I need this PR to start the next round of alpha testing.

briandobbins commented 2 years ago

I have not, but I'll set it up right now and get back to you this afternoon. Sorry for the delay!

On Thu, Jul 14, 2022 at 11:09 AM fischer-ncar @.***> wrote:

@briandobbins https://github.com/briandobbins have you had a chance to try this on aws. I need this PR to start the next round of alpha testing.

— Reply to this email directly, view it on GitHub https://github.com/ESMCI/ccs_config_cesm/pull/51#issuecomment-1184684624, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL2HPINMNMOYN7NKZO6NYDVUBCS3ANCNFSM53ML5EGQ . You are receiving this because you were mentioned.Message ID: @.***>

briandobbins commented 2 years ago

This worked fine; you're all set, Chris. Thanks!

On Thu, Jul 14, 2022 at 11:41 AM Brian Dobbins @.***> wrote:

I have not, but I'll set it up right now and get back to you this afternoon. Sorry for the delay!

  • Brian

On Thu, Jul 14, 2022 at 11:09 AM fischer-ncar @.***> wrote:

@briandobbins https://github.com/briandobbins have you had a chance to try this on aws. I need this PR to start the next round of alpha testing.

— Reply to this email directly, view it on GitHub https://github.com/ESMCI/ccs_config_cesm/pull/51#issuecomment-1184684624, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL2HPINMNMOYN7NKZO6NYDVUBCS3ANCNFSM53ML5EGQ . You are receiving this because you were mentioned.Message ID: @.***>

fischer-ncar commented 2 years ago

@briandobbins , can you approve the changes, thanks.