search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
160 stars 207 forks source link

ERROR: No results found for variable CAM_DYCORE #3452

Closed jedwards4b closed 4 years ago

jedwards4b commented 4 years ago

This message is printed to all build logs when cam is not a component, the FV3 build needs to be refactored to avoid this. To reproduce 1075 ./create_newcase --case foo --compset X --res f19_g16 1076 cd foo 1077 ./case.setup 1078 ./case.build 1079 zgrep CAM $EXEROOT/.bldlog.

jedwards4b commented 4 years ago

@jtruesdal have you addressed this issue yet?

jtruesdal commented 4 years ago

Sorry this fell through. I do remember looking at this early on and not seeing an immediate solution. Do you have any ideas of where to start looking. I will look into this today.

jt

On Wed, Apr 22, 2020 at 10:15 AM jedwards4b notifications@github.com wrote:

@jtruesdal https://github.com/jtruesdal have you addressed this issue yet?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ESMCI/cime/issues/3452#issuecomment-617879090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG3NX5Z4YQ2WVNT5IIUD33RN4J3VANCNFSM4LHNTAQA .

jedwards4b commented 4 years ago

@jtruesdal The problem is that you need CAM_DYCORE in the link step right? I think this will do it:

COMP_ATM = ?= $(shell $(CASEROOT)/xmlquery --caseroot $(CASEROOT) COMP_ATM --value)                                   
ifeq ($(COMP_ATM),cam)                                                                                                
  CAM_DYCORE ?= $(shell $(CASEROOT)/xmlquery --caseroot $(CASEROOT) CAM_DYCORE --value)                               

  ifeq ($(CAM_DYCORE),fv3)                                                                                            
    FV3CORE_LIBDIR:=$(abspath $(EXEROOT)/atm/obj/atmos_cubed_sphere)                                                  
    INCLDIR+=-I$(FV3CORE_LIBDIR) -I$(FV3CORE_LIBDIR)/../ -I../$(INSTALL_SHAREDPATH)/include \                         
       -I../$(CSM_SHR_INCLUDE) -I$(abspath $(EXEROOT)/FMS) -I$(CIMEROOT)/../libraries/FMS/src/include                 
  endif                                                                                                               
endif
jtruesdal commented 4 years ago

Thanks again for your help. Now that I see this I think you gave me this fix before and when I tried it there was a subtle issue that prevented it from working with FV3. I can't remember but will test it again today and follow through this time.

jtruesdal commented 4 years ago

Hi Jim:

I had to modify one line but you're proposed change worked for FV3 and got rid of CAM_DYCORE warnings in the log file. Below are the Makefile lines that worked (note additional strip command when comparing COMP_ATM). Do you want me to create a PR with this change?

COMP_ATM ?= $(shell $(CASEROOT)/xmlquery --caseroot $(CASEROOT) COMP_ATM --value)
ifeq ($(strip $(COMP_ATM)),cam)

CAM_DYCORE ?= $(shell $(CASEROOT)/xmlquery --caseroot $(CASEROOT) CAM_DYCORE --value) ifeq ($(CAM_DYCORE),fv3) FV3CORE_LIBDIR:=$(abspath $(EXEROOT)/atm/obj/atmos_cubed_sphere) INCLDIR+=-I$(FV3CORE_LIBDIR) -I$(FV3CORE_LIBDIR)/../ -I../$(INSTALL_SHAREDPATH)/include -I../$(CSM_SHR_INCLUDE) -I$(abspath $(EXEROOT)/FMS) -I$(CIMEROOT)/../libraries/FMS/src/include endif endif

jedwards4b commented 4 years ago

Yes, that would be great. Maybe the email format is a bit weird - but can you add some indentation in the Makefile.

On Mon, Apr 27, 2020 at 5:05 PM jtruesdal notifications@github.com wrote:

Hi Jim:

I had to modify one line but you're proposed change worked for FV3 and got rid of CAM_DYCORE warnings in the log file. Below are the Makefile lines that worked (note additional strip command when comparing COMP_ATM). Do you want me to create a PR with this change?

COMP_ATM ?= $(shell $(CASEROOT)/xmlquery --caseroot $(CASEROOT) COMP_ATM --value) ifeq ($(strip $(COMP_ATM)),cam)

CAM_DYCORE ?= $(shell $(CASEROOT)/xmlquery --caseroot $(CASEROOT) CAM_DYCORE --value) ifeq ($(CAM_DYCORE),fv3) FV3CORE_LIBDIR:=$(abspath $(EXEROOT)/atm/obj/atmos_cubed_sphere) INCLDIR+=-I$(FV3CORE_LIBDIR) -I$(FV3CORE_LIBDIR)/../ -I../$(INSTALL_SHAREDPATH)/include -I../$(CSM_SHR_INCLUDE) -I$(abspath $(EXEROOT)/FMS) -I$(CIMEROOT)/../libraries/FMS/src/include endif endif

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ESMCI/cime/issues/3452#issuecomment-620281082, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOXUGBWF3HCNZXFQ5OT2FLROYFURANCNFSM4LHNTAQA .

-- Jim Edwards

CESM Software Engineer National Center for Atmospheric Research Boulder, CO

jedwards4b commented 4 years ago

Are you planning to submit a PR with this change? @jtruesdal

jtruesdal commented 4 years ago

I'm running the cime test right this minute. I also included a one line change to config_grids to fix an issue with C96_C96_mg17. Tested and works fine. Will that be OK? Without it the FV3 C96_C96_mg17 (default 1 degree run) is broken for anything but fully coupled.

jt

On Fri, May 1, 2020 at 6:22 PM jedwards4b notifications@github.com wrote:

Are you planning to submit a PR with this change? @jtruesdal https://github.com/jtruesdal

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ESMCI/cime/issues/3452#issuecomment-622591053, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG3NX57BC3CYFJNOJY57P3RPNDQRANCNFSM4LHNTAQA .

jedwards4b commented 4 years ago

yes, no problem - thanks.