search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
162 stars 207 forks source link

remove cprnc to new repo #4522

Closed jedwards4b closed 11 months ago

jedwards4b commented 12 months ago

Puts the cprnc program into it's own repo Test suite: scripts_regression_tests on derecho Test baseline: Test namelist changes: Test status: bit for bit

Fixes

User interface changes?: cprnc is now external and added with Externals_cime.cfg This means that in your Externals.cfg you will need: externals = Externals_cime.cfg

Update gh-pages html (Y/N)?:

jasonb5 commented 11 months ago

@jedwards4b I'll need to push a few changes for E3SM to support this.

jedwards4b commented 11 months ago

@jasonb5 please do. I think you already have permissions but I'll confirm.

rljacob commented 11 months ago

Please also add an entry in .gitmodules for those of us using submodules.

jedwards4b commented 11 months ago

I see the problem - you are checking out cesm master which does not yet have the additional hook needed to checkout cprnc. I can't figure out where the external scripts used in testing.yml are located - (init_cime, init_e3sm, entrypoint.sh) @jasonb5 can you document these in testing.yml?

jasonb5 commented 11 months ago

@jedwards4b checkout_externals is called in entrypoint.sh in the init_cesm function. I can add some documents to the testing workflow yaml.

jedwards4b commented 11 months ago

We're getting closer - thank you @jasonb5

jasonb5 commented 11 months ago

@jedwards4b Looks like the cprnc repo is missing a Makefile required for one of the E3Sm tests.

jedwards4b commented 11 months ago

It shouldn't need a Makefile - it's a cmake build.

jasonb5 commented 11 months ago

Looks like there's a test script that was using the makefile file, I'll look into updating it to use cmake.

jedwards4b commented 11 months ago

@jasonb5 I think I have it fixed - should I push the change?

jasonb5 commented 11 months ago

@jedwards4b Go ahead and push it.

jedwards4b commented 11 months ago

@mnlevy1981 I'm trying to run the test_get_domain.sh script on derecho - it's looking for a file that doesn't exist: ${inputdata_root}/cpl/gridmaps/oQU240/map_oQU240_to_ne4np4_aave.160614.nc

jasonb5 commented 11 months ago

Here's the source for those files. https://github.com/ESMCI/cime/blob/f5fd575446cde78164605d5b325f0f151e877bbe/docker/Dockerfile#L26-L28

jedwards4b commented 11 months ago

try to push since I don't have data for a local test

jasonb5 commented 11 months ago

That's fine, the changes look right, it's the same route I was on.