search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
162 stars 207 forks source link

Remove manage externals #4555

Closed jedwards4b closed 10 months ago

jedwards4b commented 10 months ago

Removes the need for manage_externals from CESM. We are still early in the discussion stage, so will set to draft.

Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

jedwards4b commented 10 months ago

@jasonb5 I'm going to need your help again. I need to update entrypoint.sh for the tests to run on this branch, I made the changes I think I need on the entrypoint.sh of this branch, but it doesn't use that one.

jasonb5 commented 10 months ago

@jedwards4b I see the issue, I'll need to manually build and push the container. I'll work on fixing these workflows shortly. @jgfouca Do we need submodules to be in the git@github.com: form?

jgfouca commented 10 months ago

@jasonb5 , yes, it is helpful to have submodules in ssh form.

jedwards4b commented 10 months ago

@jasonb5 I think I already did that here: https://github.com/ESMCI/cime/pull/4556

jasonb5 commented 10 months ago

@jedwards4b I'm referring to .gitmodules in this branch.

jedwards4b commented 10 months ago

I just realized that this is going to cause e3sm problems because you will get more than you want. I may need to think of another way to do this.

rljacob commented 10 months ago

Maybe put all those in a .gitmodules in https://github.com/ESCOMP/CESM ?

jedwards4b commented 10 months ago

@rljacob They are already there - the point of this .gitmodules was just to be able to do github testing without getting all of cesm. I can figure out another way to do that.

jedwards4b commented 10 months ago

I think that I just need to withdraw this PR until the CESM developers decide if they want to remove manage externals or not. If they do decide to remove manage externals then I will put the new cesm on the trunk before reopening this PR.