search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
161 stars 206 forks source link

Loosen type for module command to allow options to be passed before subcommand #4565

Closed mvdebolskiy closed 8 months ago

mvdebolskiy commented 8 months ago

This is needed for some versions of lua, since otherwise it will not recognize options like --force and --quiet which will not allow a case to be created. NCName, on the other hand does not allow to -- to be start of the name.

Similar to #4375

Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?: N Update gh-pages html (Y/N)?: N

jedwards4b commented 8 months ago

@mvdebolskiy we already have a mechanism to provide this.

Will allow lua to return errors without triggering a cime failure.
jedwards4b commented 8 months ago

I guess maybe I can see a case where the allow_error feature may not be adequate but could you confirm please.

mvdebolskiy commented 8 months ago

That option works. The model builds. The only concern I have is when sigma2 upgrades the machines and deprecates some toolchains, it will be harder to debug. But all good. Should I close this?

jedwards4b commented 8 months ago

This is a concern on every machine, not in our control.