search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
162 stars 207 forks source link

case.submit: Always try to download input data #4581

Closed jgfouca closed 9 months ago

jgfouca commented 9 months ago

We don't want test cases downloading data while on a compute node if it can be avoided. It's harmless to call check_all_input_data twice, so let's have the case.submit call handle the 99% of cases where the main case will download all the inputs needed for the case/test. We keep the download calls in system_tests_common.py just in case case2 of a compare-two test needs more inputs.

Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

jgfouca commented 9 months ago

@jasonb5 , you were the one that put the TEST check in, so please take a look at this.

jasonb5 commented 9 months ago

@jgfouca This outstanding fail is the same a https://github.com/ESMCI/cime/pull/4584. It's due to a bug that I missed in https://github.com/ESMCI/cime/pull/4580. I'll have a fix shortly.