search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
162 stars 207 forks source link

Testmods don't check that folder contains valid testmods #4601

Open bartgol opened 8 months ago

bartgol commented 8 months ago

I recently made a typo when submitting a test, which got undetected. I had some testmods in a fews subfolders of a main folder. Let's call the parent folder "root" and the subfolders "1", "2', and so on. The correct testmod were then <test>.root-1, <test>.root-2, and so on. However, I accidentally just typed <test>.root. Since the "root" folder existed, CIME did not complain. However, it also did not add any testmod, since no shell_commands was in that folder (nor any user_nl_XYZ).

I think it would be nice if CIME checked that the testmod does something, precicely to avoid cases where the user specifies only part of the path/to/testmod. This could be implemented either as an error or warning, depending on how sure we are that not finding valid mods is indeed an error rather than "a coincidence" (maybe inside some general purpose script). But having at least a warning would allow one to see in the logs that a testmod they tought was added was not indeed added.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.