search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
161 stars 206 forks source link

Remove the standard_name length restriction for CAM-SIMA #4627

Closed jtruesdal closed 4 months ago

jtruesdal commented 4 months ago

Remove the standard_name 64 character length restriction and allow strings of 1 or more characters. This corrects a CAM-SIMA error for the new dadadj CCPP routine which contains a namelist entry with a standard name greater than the current 63 character limit. The new pattern match removes a length restriction but is consistent with the Guidelines for Construction of CF Standard Names which is adopted in the CCPP Standard Name Rules (rule 2).

Test suite: Built and ran a CAM-SIMA snapshot test with the new routine and I also ran a create_test case with CAM on izumi. Test baseline: cime6.0.236_httpsbranch01 Test namelist changes: N/A Test status: bit for bit

Fixes #4625

User interface changes?:Remove string length restriction for standard_name type.

Update gh-pages html (Y/N)?:N

jtruesdal commented 4 months ago

@jedwards4b What is the procedure for getting this reviewed and merged? I looked at the workflow doc but didn't see any specifics about who to assign ie. who is authorized to merge? Just FYI Steve G. did comment on the fix via the associated issue. Do I pick reviewers?