search

ESMCI / cime

Common Infrastructure for Modeling the Earth
http://esmci.github.io/cime
Other
162 stars 209 forks source link

error in timing makefile #4639

Closed dudek313 closed 2 months ago

dudek313 commented 5 months ago

commit a488510bc24b981809b3dda5ee7b9809a7fc9616 (HEAD, tag: cime5.6.49

cesm/cime/src/share/timing/Makefile

Line 74-75:

-       cp -p *.$(MOD_SUFFIX) $(SHAREDPATH)/include
-       cp -p libgptl.a $(SHAREDPATH)/lib
+       cp -p $(GPTL_DIR)/*.$(MOD_SUFFIX) $(SHAREDPATH)/include
+       cp -p $(GPTL_DIR)/libgptl.a $(SHAREDPATH)/lib
jedwards4b commented 5 months ago

@dudek313 What is the issue you intended to report herein?

jedwards4b commented 5 months ago

I think that I see what you want to do - but I can't read it as written. Please clarify and consider opening a PR with your suggested change.

dudek313 commented 5 months ago

Apologies @jedwards4b I was in a bit of a haste.

The makefile has a couple of cp commands that don't have the base path $(GPTL_DIR), so the copy fails.

For example, I think that line 74 should be: cp -p $(GPTL_DIR)/*.$(MOD_SUFFIX) $(SHAREDPATH)/include

What makes me uneasy is that this is supposed to be the production branch so something like that would be caught early. Perhaps this is the time to disclose that I am migrating from a really old version of CESM (1.0.6) ;)

jedwards4b commented 5 months ago

The maint-5.6 branch has, as you pointed out, been stable for a very long time. This code has not been a problem for anyone that I am aware of. If you can document an error, providing all of the relevant information to reproduce the error we will be happy to address it.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 5 days with no activity.