search

ESMCI / cmeps-cime

This is a "fork" of the cime repository that has the development version of the nuopc CMEPS driver and mediator
Other
0 stars 0 forks source link

updates to dictionary and clocks #46

Closed mvertens closed 6 years ago

mvertens commented 6 years ago

Updates for NUOPC dictionary and driver clock

This PR does several things: 1) create a yaml dictionary (fd.yaml) 2) removes the creation of dictionary metadata from esmFlds.F90 3) calls esmFlds.F90 only from the mediator 4) introduces a new mechanism for creating a driver clock and removes all of the component clocks created in esm.F90 5) removes the cpl7 based time management utility seq_timemgr_mod.F90

Test suite: testlist_cmeps.xml on cheyenne The only true test failures are

ERR_Vmct_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io
ERS_Vmct_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap
ERS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap
ERS_Vmct_Ln9.f19_g16.X.cheyenne_intel

Test baseline: aug28 Test namelist changes: yes Test status: bit for bit Fixes: None User interface changes?: No Update gh-pages html (Y/N)?: No Code review:

rsdunlapiv commented 6 years ago

Looks like Jim requested some code cleanup. I went ahead and kicked off tests in the meantime to catch any early issues.

dunlap@cheyenne3:~/UFSCOMP.sept6/cime/scripts> qcmd -l walltime=04:00:00 -- ./create_test --xml-machine cheyenne --xml-testlist testlist_cmeps.xml --baseline-root /glade/scratch/dunlap/BASELINES --compare aug28 --test-id sept7
jedwards4b commented 6 years ago

I suggested some code clean up but given the time line I suggest we go ahead and merge when testing is complete.

On Fri, Sep 7, 2018 at 8:12 AM, Rocky Dunlap notifications@github.com wrote:

Looks like Jim requested some code cleanup. I went ahead and kicked off tests in the meantime to catch any early issues.

dunlap@cheyenne3:~/UFSCOMP.sept6/cime/scripts> qcmd -l walltime=04:00:00 -- ./create_test --xml-machine cheyenne --xml-testlist testlist_cmeps.xml --baseline-root /glade/scratch/dunlap/BASELINES --compare aug28 --test-id sept7

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ESMCI/cmeps-cime/pull/46#issuecomment-419452205, or mute the thread https://github.com/notifications/unsubscribe-auth/AF16GHrYvL0k8RMVQTIgjTf9qxEPCrVHks5uYn7lgaJpZM4WeFEh .

-- Jim Edwards

CESM Software Engineer National Center for Atmospheric Research Boulder, CO

rsdunlapiv commented 6 years ago

Here are the failures:

dunlap@cheyenne1:/glade/scratch/dunlap> ./cs.status.sept7b | grep "FAIL "
    FAIL ERR_Vmct_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io COMPARE_base_rest
    FAIL ERR_Vmct_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io BASELINE aug28
    FAIL ERR_Vnuopc_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io NLCOMP
    FAIL ERR_Vnuopc_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io COMPARE_base_rest
    FAIL ERR_Vnuopc_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io BASELINE aug28
    FAIL ERS_Vmct_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap COMPARE_base_rest
    FAIL ERS_Vmct_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap BASELINE aug28
    FAIL ERS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap COMPARE_base_rest
    FAIL ERS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap BASELINE aug28
    FAIL ERS_Vmct_Ln9.f19_g16.X.cheyenne_intel COMPARE_base_rest
    FAIL ERS_Vnuopc_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap NLCOMP
    FAIL ERS_Vnuopc_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap RUN time=606
    FAIL ERS_Vnuopc_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap NLCOMP
    FAIL ERS_Vnuopc_Ld5.T62_g37.DTEST.cheyenne_intel.cice-nuopc_cap NLCOMP
    FAIL ERS_Vnuopc_Ln5.f19_g16.F2000Nuopc.cheyenne_intel.cam-nuopc_cap NLCOMP
    FAIL ERS_Vnuopc_Ln5.f45_f45_mg37.I2000Clm50SpNuopc.cheyenne_intel.clm-nuopc_cap NLCOMP
    FAIL ERS_Vnuopc_Ln5.ne16_ne16_mg17.QPC4.cheyenne_intel.cam-nuopc_cap NLCOMP
    FAIL ERS_Vnuopc_Ln9.f19_g16.X.cheyenne_intel NLCOMP
    FAIL ERS_Vnuopc_Ln9.T31_g37_rx1.A.cheyenne_intel NLCOMP
    FAIL SMS_Vmct_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io BASELINE aug28
    FAIL SMS_Vmct_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap BASELINE aug28
    FAIL SMS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap BASELINE aug28
    FAIL SMS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap MEMCOMP Error: Memory usage increase > 10% from baseline
    FAIL SMS_Vnuopc.f19_g16.X.cheyenne_intel NLCOMP
    FAIL SMS_Vnuopc_Ld1.T31_g37_rx1.A.cheyenne_intel NLCOMP
    FAIL SMS_Vnuopc_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io NLCOMP
    FAIL SMS_Vnuopc_Ld5.f19_g16.BMOM.cheyenne_intel.allactive-nuopc_cap_io BASELINE aug28
    FAIL SMS_Vnuopc_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap NLCOMP
    FAIL SMS_Vnuopc_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap BASELINE aug28
    FAIL SMS_Vnuopc_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap NLCOMP
    FAIL SMS_Vnuopc_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap BASELINE aug28
    FAIL SMS_Vnuopc_Ld5.T62_g37.DTEST.cheyenne_intel.cice-nuopc_cap NLCOMP
    FAIL SMS_Vnuopc_Ln5.f19_g16.F2000Nuopc.cheyenne_intel.cam-nuopc_cap NLCOMP
    FAIL SMS_Vnuopc_Ln5.f45_f45_mg37.I2000Clm50SpNuopc.cheyenne_intel.clm-nuopc_cap NLCOMP
    FAIL SMS_Vnuopc_Ln5.ne16_ne16_mg17.QPC4.cheyenne_intel.cam-nuopc_cap NLCOMP
rsdunlapiv commented 6 years ago

This one was due to job timeout so resubmitted manually: FAIL ERS_Vnuopc_Ld5.T62_g16.CMOM.cheyenne_intel.mom-nuopc_cap RUN time=606