search

ESMG / pyroms

Python tools for the Regional Ocean Modeling System (ROMS)
Other
141 stars 88 forks source link

README.md code typo #27

Open hadfieldnz opened 5 years ago

hadfieldnz commented 5 years ago

In README.md for the installation of the scrip extension we have

$ make DEVELOP=1 PREFIX=$PREFIX install $ mv -vf scrip*.so ../../../pyroms scrip.cpython-37m-x86_64-linux-gnu.so -> ../../../pyroms/scrip.cpython-37m-x86_64-linux-gnu.so

That last mv command should not have a dollar sign in front: it's something make runs. Also the current makefile has a cp command, which is more in the spirit of "make install". So it should be

$ make DEVELOP=1 PREFIX=$PREFIX install cp -vf scrip*.so ../../../pyroms scrip.cpython-37m-x86_64-linux-gnu.so -> ../../../pyroms/scrip.cpython-37m-x86_64-linux-gnu.so

kshedstrom commented 5 years ago

I noticed that make had run the cp command so that I didn't have to. I found it confusing that the README seemed to be telling me to run it.