Arctan issue with make_tide

ESMG / pyroms

Python tools for the Regional Ocean Modeling System (ROMS)

Other

141 stars 88 forks source link

Arctan issue with make_tide #41

Closed fdufois closed 2 years ago

fdufois commented 2 years ago

Hi, I might be missing something but I think that there is an issue in make_tide.py. After comparing with the outputs from the croco_tools I noticed that the phases were all between -90 and 90°. I think np.arctan2 should be used instead of np.arctan to correct the issue. The results are pretty similar now (considering the TPXO version used in the croco_tools is different (v7)). Please let me know if I'm wrong. Thanks

kshedstrom commented 2 years ago

Yes, I'm sure you are right. I just pushed the change. Can you confirm that I got it right? In future, the recommended approach is a pull request.

fdufois commented 2 years ago

It's all good now. Thanks for pushing that.