ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Download ICON grid without locking #2359

Closed bouweandela closed 6 months ago

bouweandela commented 6 months ago

Description

The file lock used in the ICON grid download function is causing issues with parallelization. This pull request removes the use of that lock.

See https://github.com/ESMValGroup/ESMValCore/issues/2341#issuecomment-1968744040.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.12%. Comparing base (2be264d) to head (cf5f9f9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2359 +/- ## ======================================= Coverage 94.11% 94.12% ======================================= Files 241 241 Lines 13381 13387 +6 ======================================= + Hits 12594 12600 +6 Misses 787 787 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.