Closed valeriupredoi closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.12%. Comparing base (
bf04feb
) to head (4b8ae81
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could over of you please give a bit more detail about why this test is failing?
This test tests a fix that converts a non-CF-compliant netCDF file into a CF-compliant file. One issue of this netCDF file is that the units of the bounds differ to those of the points.
Since 3.8, iris now ignores bounds with different (incompatible) units than the points. I think we need to wait for a reply of the iris people before we can properly fix this. It would be especially helpful to know if we can somehow retrieve the bounds after loading the cube.
thanks, Manu! And yes, valid question, Bouwe :beer:
Just to make it clear that this is broken with iris 3.8, could you please open an issue in our own repository too with this description and which datasets can now now longer be fixed by ESMValCore? I'm not sure if the iris folks have plans to support all kinds of non-compliant data, so the fix may need an update if we want to use iris 3.8.
Description
Issue described in https://github.com/SciTools/iris/issues/5806 and reported internally in #2357
Remember to plug intended behaviour after Iris folk fix that, or, un-xfail the test
@schlunma gives a nice overview of the test: This test tests a fix that converts a non-CF-compliant netCDF file into a CF-compliant file. One issue of this netCDF file is that the units of the bounds differ to those of the points.
Since 3.8, iris now ignores bounds with different (incompatible) units than the points. I think we need to wait for a reply of the iris people before we can properly fix this. It would be especially helpful to know if we can somehow retrieve the bounds after loading the cube.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐ Technical or ๐งช Scientific review.
To help with the number pull requests: