ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Fix `positive` attributes in custom CMOR variables #2380

Closed schlunma closed 5 months ago

schlunma commented 5 months ago

Description

This PR fixes positive attributes in custom CMOR variables:

This PR also adds missing tests for these derived variables to improve our overall test coverage.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number pull requests:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.25%. Comparing base (3a0b49f) to head (e3a33e7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2380 +/- ## ========================================== + Coverage 94.10% 94.25% +0.15% ========================================== Files 246 246 Lines 13477 13483 +6 ========================================== + Hits 12682 12708 +26 + Misses 795 775 -20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.