Remove custom fix for concatenation of aux factories now that bug in iris is solved

schlunma commented 4 months ago

Description

For at least 6 years, iris dropped derived coordinates (i.e., aux factories) during concatenation (see https://github.com/SciTools/iris/issues/2478). For this reason, we implemented our own custom code to solve this:

https://github.com/ESMValGroup/ESMValCore/blob/1f73cc0ca565d37b51c295e558da0f6883a2e8f1/esmvalcore/preprocessor/_io.py#L39

Since the issue is solved now since iris 3.5, this PR removes the corresponding custom code in ESMValCore. I did not remove a tiny test that checks if the actual concatenation still works; and indeed, it does (also without our custom code) 🚀

Closes #2284

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🧪 The new functionality is relevant and scientifically sound
[x] 🛠 This pull request has a descriptive title and labels
[x] 🛠 Code is written according to the code quality guidelines
[x] 🧪 and 🛠 Documentation is available
[x] 🛠 Unit tests have been added
[x] 🛠 Changes are backward compatible
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 The list of authors is up to date
[x] 🛠 All checks below this pull request were successful

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.28%. Comparing base (d128753) to head (f8832e7).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2392 +/- ## ========================================== - Coverage 94.29% 94.28% -0.01% ========================================== Files 246 246 Lines 13532 13511 -21 ========================================== - Hits 12760 12739 -21 Misses 772 772 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

schlunma commented 4 months ago

Well, the good code is now in iris, so I don't feel too bad about it 😄

ESMValGroup / ESMValCore