ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Pin pandas yet again :panda_face: `test_icon` fails again with pandas=2.2.2 #2394

Closed valeriupredoi closed 4 months ago

valeriupredoi commented 4 months ago

Description

Tests are failing with the same issue we had in the past, described by @schlunma in https://github.com/ESMValGroup/ESMValCore/pull/2305 and with an original bug report in pandas at https://github.com/pandas-dev/pandas/issues/57002 - they just switched the milestone for that for 2.2.3 apparently!


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.28%. Comparing base (e2c68e7) to head (52073c5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2394 +/- ## ======================================= Coverage 94.28% 94.28% ======================================= Files 246 246 Lines 13511 13511 ======================================= Hits 12739 12739 Misses 772 772 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 4 months ago

thanks a lot, Manu! I too agree with fixing the test rather than pinning the ninja bears, but I didn't have the will to look at it closer - good call you did, you mind opening a PR with the fix pls, bud? :beer: In the meantime this will do :panda_face: