ESMValGroup / ESMValCore

ESMValCore: A community tool for pre-processing data from Earth system models in CMIP and running analysis scripts.
https://www.esmvaltool.org
Apache License 2.0
42 stars 38 forks source link

Pin esmpy <8.6.0 #2402

Closed valeriupredoi closed 3 months ago

valeriupredoi commented 3 months ago

Description

issues with iris-esmf-regrid mentioned by @schlunma in https://github.com/SciTools-incubator/iris-esmf-regrid/pull/342#issuecomment-2092921514 and confirmed by me in MO/ANCIL-ANTS, see https://github.com/valeriupredoi/ANTS_stuff/blob/main/ANTS_JASMIN.md - no issue raised at ESMF Github just yet though, so possibly just an iris-esmf-regrid issue, but pinning that instead is no bueno, since we'd better have their latest version up, and that works fine with older ESMF/Py's according to Manu.

~Also remove esmpy from setup.py~ -> esmpy is not on PyPI, they get their source for the package straight from Github packages https://github.com/conda-forge/esmpy-feedstock/blob/main/recipe/meta.yaml but we should still keep it for regulations


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.


To help with the number pull requests:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.44%. Comparing base (8fa5aa4) to head (9445b8c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2402 +/- ## ======================================= Coverage 94.44% 94.44% ======================================= Files 246 246 Lines 13745 13745 ======================================= Hits 12981 12981 Misses 764 764 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valeriupredoi commented 3 months ago

@bouweandela as per our discussion at the TLT I have readded esmpy to setup.py in https://github.com/ESMValGroup/ESMValCore/pull/2402/commits/63e20c2b34e87567288b378f853e0d6f898fb83e - if you got a sec, pls re-review and merge :beer:

valeriupredoi commented 3 months ago

muchos bedankt, bud :beer: