Closed valeriupredoi closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.44%. Comparing base (
8fa5aa4
) to head (9445b8c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bouweandela as per our discussion at the TLT I have readded esmpy
to setup.py
in https://github.com/ESMValGroup/ESMValCore/pull/2402/commits/63e20c2b34e87567288b378f853e0d6f898fb83e - if you got a sec, pls re-review and merge :beer:
muchos bedankt, bud :beer:
Description
issues with iris-esmf-regrid mentioned by @schlunma in https://github.com/SciTools-incubator/iris-esmf-regrid/pull/342#issuecomment-2092921514 and confirmed by me in MO/ANCIL-ANTS, see https://github.com/valeriupredoi/ANTS_stuff/blob/main/ANTS_JASMIN.md - no issue raised at ESMF Github just yet though, so possibly just an iris-esmf-regrid issue, but pinning that instead is no bueno, since we'd better have their latest version up, and that works fine with older ESMF/Py's according to Manu.
~Also remove
esmpy
fromsetup.py
~ ->esmpy
is not on PyPI, they get their source for the package straight from Github packages https://github.com/conda-forge/esmpy-feedstock/blob/main/recipe/meta.yaml but we should still keep it for regulationsChecklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐ Technical or ๐งช Scientific review.
To help with the number pull requests: